Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move intro docs from flytesnacks to flyte #4814

Merged
merged 7 commits into from
Feb 5, 2024

Conversation

ppiegaze
Copy link
Member

@ppiegaze ppiegaze commented Feb 1, 2024

Covers DOCS-274 which is the first step of DOCS-273

Move the onboarding guide from flytesnacks to flyte repo without making any other visual changes to the docs site

@ppiegaze ppiegaze requested a review from neverett February 1, 2024 11:33
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. documentation Improvements or additions to documentation labels Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aedde59) 58.51% compared to head (e4a9fac) 58.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4814      +/-   ##
==========================================
+ Coverage   58.51%   58.97%   +0.46%     
==========================================
  Files         493      644     +151     
  Lines       42771    55145   +12374     
==========================================
+ Hits        25026    32522    +7496     
- Misses      15749    20049    +4300     
- Partials     1996     2574     +578     
Flag Coverage Δ
unittests 58.97% <ø> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Peeter Piegaze <[email protected]>
@ppiegaze ppiegaze force-pushed the docs/peeter/bring-in-flytesnacks-content branch from a624199 to b880d06 Compare February 2, 2024 12:00
Signed-off-by: Peeter Piegaze <[email protected]>
Signed-off-by: Peeter Piegaze <[email protected]>
@ppiegaze ppiegaze requested a review from cosmicBboy February 5, 2024 12:52
Signed-off-by: Peeter Piegaze <[email protected]>
ppiegaze and others added 2 commits February 5, 2024 15:47
Signed-off-by: Peeter Piegaze <[email protected]>
@cosmicBboy
Copy link
Contributor

I updated conf.py to always use jupytext to convert .md files to notebooks. I also added back the yaml frontmatter, but just the minimal amount of config needed to render code. This will only be needed in .md files that contain {code-cell} ipython3 blocks, since the myst extension needs to know how to execute the code in these cells.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 5, 2024
@cosmicBboy cosmicBboy merged commit d064b19 into master Feb 5, 2024
49 checks passed
@cosmicBboy cosmicBboy deleted the docs/peeter/bring-in-flytesnacks-content branch February 5, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants